Rename well_bottoms to well_bottoms.json #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Description** This PR fixes a critical issue causing severe console spam and TPS drops during world generation, specifically related to the Pillager structures. **The Issue** When generating chunks containing this structure, the server console is flooded with the following error: `[Worker-Main-1/WARN] [minecraft/JigsawPlacement]: Empty or non-existent pool: structory:harvest/well_bottoms` This causes significant lag (TPS drops) and slows down pre-generation tools like Chunky, as the game fails to locate the requested template pool. **The Cause** This file was named without the .json **The Fix** Just had to add the .json in the name of the file and the error disappears. This successfully resolves the "non-existent pool" error, stops the console spam, and restores normal world generation performance.
Contributor
|
I'll look into it for the next version. This is one of those bugs where some variation of it has existed for several years, and every time I "fix" it I somehow accidentally break something else. I should note, due to the way our Github repos are set up, I will be closing the PR instead of merging, and be manually making the changes in our dev repo. Inconsequential side note: are you certain it's causing significant lag? That surprises me, I would expect the game to search for the file, not find it, spit out an error, and continue. An extra step or two, but it should not dramatically slow down Chunky, it's not like this happens multiple times per chunk. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version
Minecraft Neoforge 1.21.1
Description
This PR fixes a critical issue causing severe console spam and TPS drops during world generation, specifically related to the Pillager structures.
The Issue
When generating chunks containing this structure, the server console is flooded with the following error:
[Worker-Main-1/WARN] [minecraft/JigsawPlacement]: Empty or non-existent pool: structory:harvest/well_bottomsThis causes significant lag (TPS drops) and slows down pre-generation tools like Chunky, as the game fails to locate the requested template pool.
The Cause
This file was named without the .json
The Fix
Just had to add the .json in the name of the file and the error disappears. This successfully resolves the "non-existent pool" error, stops the console spam, and restores normal world generation performance.